D23984: [System Settings] redesign intro page

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> introPage.qml:65
> +                text: i18n("System Settings")
> +                font.pointSize: 16
> +            }

Hardcoding sizes is generally frowned upon.

Partly because things are user-configurable, partly because if every dev hardcodes their own sizes we'll have an inconsistent mess everywhere.

This patch has quite a few. Try and see what you can get rid of

> introPage.qml:82
> +    Rectangle {
> +        property real brightness: (0.2126*Kirigami.Theme.backgroundColor.r + 0.7152*Kirigami.Theme.backgroundColor.g + 0.0722*Kirigami.Theme.backgroundColor.b)
> +        anchors {

See https://doc.qt.io/qt-5/qml-qtqml-qt.html#darker-method

> introPage.qml:89
> +        width: parent.width * 0.8
> +        height: 150
> +        color: Qt.rgba(1, 1, 1, Math.max(0.1, brightness/2)) // brighter background using some heuristic

It's best to infer this from the child.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: davidedmundson, mart, Codezela, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190916/95c258d0/attachment.html>