D23984: [System Settings] redesign intro page

Anthony Fieroni noreply at phabricator.kde.org
Mon Sep 16 11:56:13 BST 2019


anthonyfieroni added inline comments.

INLINE COMMENTS

> introPage.qml:60
> +            Kirigami.Heading {
> +                text: "KDE Plasma"
> +                font.pointSize: 24 // largest level is too small, so we use pointSize

Use i18n also only Plasma about me.

> introPage.qml:61
> +                text: "KDE Plasma"
> +                font.pointSize: 24 // largest level is too small, so we use pointSize
> +            }

Don't hardcode font sizes use level instead
https://api.kde.org/frameworks-api/frameworks-apidocs/frameworks/kirigami/html/classorg_1_1kde_1_1kirigami_1_1Heading.html#ad694a087926d5fd83edc183b526db4a4

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190916/a0ef6529/attachment.html>


More information about the Plasma-devel mailing list