D23984: [System Settings] redesign intro page

Marco Martin noreply at phabricator.kde.org
Mon Sep 16 11:29:17 BST 2019


mart added inline comments.

INLINE COMMENTS

> introPage.qml:82
> +    Rectangle {
> +        property real brightness: (0.2126*Kirigami.Theme.backgroundColor.r + 0.7152*Kirigami.Theme.backgroundColor.g + 0.0722*Kirigami.Theme.backgroundColor.b)
> +        anchors {

add in a comment a link to https://en.wikipedia.org/wiki/Relative_luminance to explain the numbers

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: mart, Codezela, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190916/4af9f682/attachment.html>


More information about the Plasma-devel mailing list