D24720: [applets/systemtray] Rewrite popups with layouts

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:48
> +                //Menu mode
> +                if (!activeApplet && hiddenItemsView.visible && LayoutMirroring.enabled === false) {
> +                    return units.smallSpacing;

!LayoutMirroring.enabled instead of === false

> ExpandedRepresentation.qml:136
> +            Layout.fillHeight: true
> +            Layout.leftMargin: hiddenItemsView.visible && activeApplet && LayoutMirroring.enabled === false ? units.largeSpacing : 0
> +            Layout.rightMargin: hiddenItemsView.visible && activeApplet && LayoutMirroring.enabled === true ? units.largeSpacing : 0

Same

> ExpandedRepresentation.qml:137
> +            Layout.leftMargin: hiddenItemsView.visible && activeApplet && LayoutMirroring.enabled === false ? units.largeSpacing : 0
> +            Layout.rightMargin: hiddenItemsView.visible && activeApplet && LayoutMirroring.enabled === true ? units.largeSpacing : 0
>          }

Same

REPOSITORY
  R120 Plasma Workspace

BRANCH
  popup-rewrite (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg, ngraham
Cc: ognarb, ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191021/ce348655/attachment-0001.html>