<table><tr><td style="">ognarb added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24720">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24720#inline-140274">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ExpandedRepresentation.qml:48</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">//Menu mode</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span style="color: #004012">activeApplet</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">hiddenItemsView</span><span class="p">.</span><span style="color: #004012">visible</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span style="color: #004012">activeApplet</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">hiddenItemsView</span><span class="p">.</span><span style="color: #004012">visible<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">LayoutMirroring</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">enabled</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">===</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">false</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">!LayoutMirroring.enabled instead of === false</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24720#inline-140273">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ExpandedRepresentation.qml:136</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">left:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">parent</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">left</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">right:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">parent</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">right</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">top:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">heading</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">bottom</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">bottom:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">bottom</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">leftMargin:</span> <span style="color: #004012">hiddenItemsView</span><span class="p">.</span><span style="color: #004012">visible</span> <span style="color: #aa2211">?</span> <span style="color: #004012">hiddenItemsView</span><span class="p">.</span><span style="color: #004012">iconColumnWidth</span> <span style="color: #aa2211">+</span> <span style="color: #aa4000">units.largeSpacing :</span> <span style="color: #601200">0</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">Layout.fillHeight:</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">true</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">Layout.leftMargin:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">hiddenItemsView</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">visible</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">activeApplet</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">LayoutMirroring</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">enabled</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">===</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">false</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">units.largeSpacing :</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">Layout.rightMargin:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">hiddenItemsView</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">visible</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">activeApplet</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">LayoutMirroring</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">enabled</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">===</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">true</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">units.largeSpacing :</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24720#inline-140272">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ExpandedRepresentation.qml:137</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">right:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">parent</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">right</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">top:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">heading</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">bottom</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">bottom:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">bottom</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">leftMargin:</span> <span style="color: #004012">hiddenItemsView</span><span class="p">.</span><span style="color: #004012">visible</span> <span style="color: #aa2211">?</span> <span style="color: #004012">hiddenItemsView</span><span class="p">.</span><span style="color: #004012">iconColumnWidth</span> <span style="color: #aa2211">+</span> <span style="color: #aa4000">units.largeSpacing :</span> <span style="color: #601200">0</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">Layout.leftMargin:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">hiddenItemsView</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">visible</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">activeApplet</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">LayoutMirroring</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">enabled</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">===</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">false</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">units.largeSpacing :</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">Layout.rightMargin:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">hiddenItemsView</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">visible</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">activeApplet</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">LayoutMirroring</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">enabled</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">===</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">true</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">units.largeSpacing :</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>popup-rewrite (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24720">https://phabricator.kde.org/D24720</a></div></div><br /><div><strong>To: </strong>filipf, Plasma, VDG, ngraham<br /><strong>Cc: </strong>ognarb, ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra<br /></div>