D25290: KCM launchfeedback : port to KConfig XT

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Nov 14 11:18:02 GMT 2019


broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:45
> onToggled is called both when it is checked, and presumably when it is unchecked (or another button is checked)
> 
> I assume we want something more like:
> 
> onToggled: {if (!checked) return;  formLayout.setCursorSettings(false,...}

`onToggled` fires when user explicitly toggles it by clicking it. Given you can't "untoggle" a radio button should be fine-ish?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25290

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191114/1c789ed3/attachment.html>


More information about the Plasma-devel mailing list