D25290: KCM launchfeedback : port to KConfig XT

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:33
> Yes, I would prefer all of this to be abstracted away from the QML, the `checked` bindings area also quite messy

I agree it's a bit tricky, we have a kind of enum choice written as a binary representation in the config file.

Will try to work it with a QML enum to make it less confusing.

> broulik wrote in main.qml:45
> `onToggled` fires when user explicitly toggles it by clicking it. Given you can't "untoggle" a radio button should be fine-ish?

According to Qt documentation :

> This signal is emitted when a checkable button is interactively toggled by the user via touch, mouse, or keyboard.

Since it's a radio button, you can't uncheck it, so the signal is emitted only when checked. I've tested both as I first tought like david said.

> broulik wrote in main.qml:94
> Use `onValueModified` which only fires when the user explicitly changes it, not because of some binding updates

Sounds better. wiil fix.

> davidedmundson wrote in main.qml:96
> taskar -> taskbar

good catch, thanks. will fix.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25290

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191114/87a55f37/attachment-0001.html>