D25290: KCM launchfeedback : port to KConfig XT

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:33
> This is a bit of a boolean trap.
> 
> We could declare an enum in QML 
> setCursorSettings(Busy | Blinking) would be a bit nicer maybe?
> 
> Up to you.

Yes, I would prefer all of this to be abstracted away from the QML, the `checked` bindings area also quite messy

> main.qml:94
> +            value: kcm.launchFeedbackSettings.cursorTimeout
> +            onValueChanged: {
> +                kcm.launchFeedbackSettings.cursorTimeout = value

Use `onValueModified` which only fires when the user explicitly changes it, not because of some binding updates

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25290

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191114/0ead2c31/attachment.html>