D25290: KCM launchfeedback : port to KConfig XT

[David Edmundson]

davidedmundson added a comment.


  Wow, we're almost at a stage where we don't need to load a C++ plugin at all.

INLINE COMMENTS

> main.qml:33
>  
> -        Connections {
> -            target: kcm
> -
> -            onBusyCursorCurrentIndexChanged: applyBusyCursorCurrentIndex()
> -
> -            onTaskManagerNotificationChanged: taskManagerNotification.checked = kcm.taskManagerNotification
> -
> -            onNotificationTimeoutChanged: notificationTimeout.value = kcm.notificationTimeout
> +        function setCursorSettings(busy, blinking, bouncing) {
> +            kcm.launchFeedbackSettings.busyCursor = busy

This is a bit of a boolean trap.

We could declare an enum in QML 
setCursorSettings(Busy | Blinking) would be a bit nicer maybe?

Up to you.

> main.qml:45
> +            checked: !kcm.launchFeedbackSettings.busyCursor && !kcm.launchFeedbackSettings.blinking && !kcm.launchFeedbackSettings.bouncing
> +            onToggled: formLayout.setCursorSettings(false, false, false)
>          }

onToggled is called both when it is checked, and presumably when it is unchecked (or another button is checked)

I assume we want something more like:

onToggled: {if (!checked) return;  formLayout.setCursorSettings(false,...}

> main.qml:96
> +                kcm.launchFeedbackSettings.cursorTimeout = value
> +                kcm.launchFeedbackSettings.taskarTimeout = value
> +            }

taskar -> taskbar

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25290

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191114/2ebb81a5/attachment-0001.html>