D19874: [Kickoff] Reduce the margins of KickoffItem

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  +1 conceptually. Since Kickoff has its own side margins, these additional margins in the items themselves are just unnecessary. I think there's already enough indentation with category headers:
  
  F6701608: Screenshot_20190319_122933.png <https://phabricator.kde.org/F6701608>
  
  Please fix the code issues I've highlighted and then let's do more testing and get it done. :)

INLINE COMMENTS

> KickoffItem.qml:102
>              left: parent.left
> -            leftMargin: (units.gridUnit * 4) - units.iconSizes.medium
> +            leftMargin: units.gridUnit * 1.5
>              verticalCenter: parent.verticalCenter

Don't multiply by non-integer values. `units.gridUnit * 1.5` is 27, so to get roughly this value without hardcoding anything, you could use `units.smallSpacing * 7` (28).

> KickoffItem.qml:155
>              right: parent.right
> -            rightMargin: units.gridUnit * 2
> +            rightMargin: units.gridUnit * 1.5
>              verticalCenter: parent.verticalCenter

Ditto

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19874

To: ndavis, #plasma, #vdg, ngraham
Cc: ngraham, filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190319/0899fd7d/attachment.html>