<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19874">View Revision</a></tr></table><br /><div><div><p>+1 conceptually. Since Kickoff has its own side margins, these additional margins in the items themselves are just unnecessary. I think there's already enough indentation with category headers:</p>

<p><a href="https://phabricator.kde.org/F6701608" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F6701608: Screenshot_20190319_122933.png</a></p>

<p>Please fix the code issues I've highlighted and then let's do more testing and get it done. :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19874#inline-111696">View Inline</a><span style="color: #4b4d51; font-weight: bold;">KickoffItem.qml:102</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">left:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">left</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">leftMargin:</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">gridUnit</span> <span style="color: #aa2211">*</span> <span class="bright"></span><span style="color: #601200"><span class="bright">4</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">units</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">iconSizes</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">medium</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">leftMargin:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">gridUnit</span> <span style="color: #aa2211">*</span> <span class="bright"></span><span style="color: #601200"><span class="bright">1.5</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">verticalCenter:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">verticalCenter</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Don't multiply by non-integer values. <tt style="background: #ebebeb; font-size: 13px;">units.gridUnit * 1.5</tt> is 27, so to get roughly this value without hardcoding anything, you could use <tt style="background: #ebebeb; font-size: 13px;">units.smallSpacing * 7</tt> (28).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19874#inline-111697">View Inline</a><span style="color: #4b4d51; font-weight: bold;">KickoffItem.qml:155</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">right:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">right</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">rightMargin:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">gridUnit</span> <span style="color: #aa2211">*</span> <span class="bright"></span><span style="color: #601200"><span class="bright">2</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">rightMargin:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">gridUnit</span> <span style="color: #aa2211">*</span> <span class="bright"></span><span style="color: #601200"><span class="bright">1.5</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">verticalCenter:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">verticalCenter</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Ditto</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19874">https://phabricator.kde.org/D19874</a></div></div><br /><div><strong>To: </strong>ndavis, Plasma, VDG, ngraham<br /><strong>Cc: </strong>ngraham, filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>