D19837: Add support for applications in KNSBackend
    Nathaniel Graham 
    noreply at phabricator.kde.org
       
    Sun Mar 17 23:09:06 GMT 2019
    
    
  
ngraham added a comment.
  Can you edit the test plan to indicate the name of an app from the store that now appears in Discover's Applications section? A quick test of this patch didn't reveal ExeQt or Treeline in Discover, which are visible on http://opendesktop.org.
INLINE COMMENTS
> KNSBackend.cpp:125
> +    m_engine->setPageSize(100);
> +    m_engine->init(m_name);
>  
Is this intentional? Don't we want to initialize it right after creating it?
REPOSITORY
  R134 Discover Software Store
REVISION DETAIL
  https://phabricator.kde.org/D19837
To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190317/c6b76600/attachment.html>
    
    
More information about the Plasma-devel
mailing list