D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ActionButton.qml:85
>              top: icon.bottom
> -            topMargin: units.smallSpacing
> +            topMargin: (softwareRendering ? 2 : 1) * units.smallSpacing
>              left: parent.left

Why do we need to change this when using software rendering?

> ActionButton.qml:90
> +        style: softwareRendering ? Text.Outline : Text.Normal
> +        styleColor: softwareRendering ? PlasmaCore.ColorScope.backgroundColor : "transparent" //no outline, doesn't matter
>          horizontalAlignment: Text.AlignHCenter

Instead of `"transparent"`, perhaps `undefined` would be better because there won't be a style for it anyway.

> UserDelegate.qml:187
>          style: softwareRendering ? Text.Outline : Text.Normal
> -        styleColor: softwareRendering ? ColorScope.backgroundColor : "transparent" //no outline, doesn't matter
> +        styleColor: softwareRendering ? PlasmaCore.ColorScope.backgroundColor : "transparent" //no outline, doesn't matter
>          elide: Text.ElideRight

Ditto

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19609

To: rooty, #plasma, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190308/5dcdf709/attachment-0001.html>