<table><tr><td style="">ngraham added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19609">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19609#inline-109900">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActionButton.qml:85</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">top:</span> <span style="color: #004012">icon</span><span class="p">.</span><span style="color: #004012">bottom</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">topMargin:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">topMargin:</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">softwareRendering</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">2</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">left:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">left</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why do we need to change this when using software rendering?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19609#inline-109897">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActionButton.qml:90</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">style:</span> <span style="color: #004012">softwareRendering</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">Text.Outline :</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">Normal</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">styleColor:</span> <span style="color: #004012">softwareRendering</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">PlasmaCore.ColorScope.backgroundColor :</span> <span style="color: #766510">"transparent"</span> <span style="color: #74777d">//no outline, doesn't matter</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">horizontalAlignment:</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">AlignHCenter</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Instead of <tt style="background: #ebebeb; font-size: 13px;">"transparent"</tt>, perhaps <tt style="background: #ebebeb; font-size: 13px;">undefined</tt> would be better because there won't be a style for it anyway.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19609#inline-109898">View Inline</a><span style="color: #4b4d51; font-weight: bold;">UserDelegate.qml:187</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">style:</span> <span style="color: #004012">softwareRendering</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">Text.Outline :</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">Normal</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">styleColor:</span> <span style="color: #004012">softwareRendering</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">ColorScope.backgroundColor :</span> <span style="color: #766510">"transparent"</span> <span style="color: #74777d">//no outline, doesn't matter</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">styleColor:</span> <span style="color: #004012">softwareRendering</span> <span style="color: #aa2211">?</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">PlasmaCore.</span>ColorScope.backgroundColor :</span> <span style="color: #766510">"transparent"</span> <span style="color: #74777d">//no outline, doesn't matter</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">elide:</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">ElideRight</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Ditto</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19609">https://phabricator.kde.org/D19609</a></div></div><br /><div><strong>To: </strong>rooty, Plasma, VDG, ngraham, filipf<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>