D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

Krešimir Čohar noreply at phabricator.kde.org
Sat Mar 9 03:41:34 GMT 2019


rooty marked 3 inline comments as done.
rooty added inline comments.

INLINE COMMENTS

> ngraham wrote in ActionButton.qml:85
> Why do we need to change this when using software rendering?

Because I feel that the icon looks too stuck-on if the margin's too great.

> ngraham wrote in ActionButton.qml:90
> Instead of `"transparent"`, perhaps `undefined` would be better because there won't be a style for it anyway.

That causes an error, see D19577 <https://phabricator.kde.org/D19577>

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19609

To: rooty, #plasma, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190309/c7a6542b/attachment.html>


More information about the Plasma-devel mailing list