D19392: shannon entropy to guess monochrome icon

[David Edmundson]

davidedmundson added a comment.


  
  
  > so, for gtk4/qt6, the base qiconengine included in qt should support whatever coloring is used, in which case i wouldn't need to do anything on my part.. tough that's for Qt6.
  
  It won't magically happen on it's own. 
  I've emailed the XDG mailing list.

INLINE COMMENTS

> desktopicon.cpp:322
>              case QVariant::Icon:
>                  img = m_source.value<QIcon>().pixmap(size, iconMode(), QIcon::On).toImage();
>                  break;

DesktopIcon::setSource takes a QVariant.  The path with the colouring is only executed if this variant is a string.

If it's already an icon we go to here directly.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19392

To: mart, #kirigami
Cc: ngraham, GB_2, ndavis, #vdg, cfeck, davidedmundson, plasma-devel, domson, dkardarakos, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190304/2e0b967b/attachment-0001.html>