<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19392">View Revision</a></tr></table><br /><div><div>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>so, for gtk4/qt6, the base qiconengine included in qt should support whatever coloring is used, in which case i wouldn't need to do anything on my part.. tough that's for Qt6.</p></blockquote>

<p>It won't magically happen on it's own. <br />
I've emailed the XDG mailing list.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19392#inline-108976">View Inline</a><span style="color: #4b4d51; font-weight: bold;">desktopicon.cpp:322</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">case</span> <span class="n">QVariant</span><span style="color: #aa2211">::</span><span style="color: #a0a000">Icon</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span class="n">img</span> <span style="color: #aa2211">=</span> <span class="n">m_source</span><span class="p">.</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">QIcon</span><span style="color: #aa2211">></span><span class="p">().</span><span class="n">pixmap</span><span class="p">(</span><span class="n">size</span><span class="p">,</span> <span class="n">iconMode</span><span class="p">(),</span> <span class="n">QIcon</span><span style="color: #aa2211">::</span><span class="n">On</span><span class="p">).</span><span class="n">toImage</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa4000">break</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">DesktopIcon::setSource takes a QVariant.  The path with the colouring is only executed if this variant is a string.</p>

<p style="padding: 0; margin: 8px;">If it's already an icon we go to here directly.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19392">https://phabricator.kde.org/D19392</a></div></div><br /><div><strong>To: </strong>mart, Kirigami<br /><strong>Cc: </strong>ngraham, GB_2, ndavis, VDG, cfeck, davidedmundson, plasma-devel, domson, dkardarakos, apol, mart, hein<br /></div>