D22429: Make "Updates Available" notification persistent but low priority

[Kai Uwe Broulik]

broulik added a comment.


  > That's kind of the point though. The user should be seeing these notifications and having to explicitly acknowledge them in some way;
  
  It wasn't nearly as annoying if a kded module was responsible for it and not the applet, so it wouldn't show up every single time I restart plasmashell which I tend to do a lot.

INLINE COMMENTS

> DiscoverNotifier.cpp:77
>      KRun::runCommand(QStringLiteral("plasma-discover"), nullptr);
> +    if (m_updatesAvailableNotification) { m_updatesAvailableNotification->close(); }
>  }

Coding style, put contents on a new line

> DiscoverNotifier.h:87
>      QNetworkConfigurationManager* m_manager = nullptr;
> +    KNotification* m_updatesAvailableNotification = nullptr;
>  };

This has to be a `QPointer<KNotification>`.

`KNotification` self-deletes when closed leading to crashes in `close()` calls below accessing garbage memory.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D22429

To: ngraham, apol, #discover_software_store
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190716/e81fc9dc/attachment.html>