D17975: [Notifications] Add padding to notifications

[David Edmundson]

davidedmundson added a comment.


  BTW, if you want a neater solution: (though consider this optional)
  
  At the moment you're moving mainLayout about and then doing maths on the window height to make sure we get the same padding underneath.
  
  Instead, use Layout.topMargin on the titleBar and Layout.bottomMargin on the lowerPart.
  
  Then QtLayouts can do all the hard work, and you're spreading this logic about to the relevant places next to where you want the padding.
  
  (you'll have to bump "import QtQuick.Layouts 1.1" to 1.2)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham
Cc: Codezela, abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190109/562c44c9/attachment-0001.html>