D17975: [Notifications] Add padding to notifications

[David Edmundson]

davidedmundson added a comment.


  @filipf 
  The media player situation was very different. This won't break anything.
  
  @rooty
  
  ((bodyText.lineCount > 1) ? 0.5 : ((bodyText.lineCount == 0) ? 0 : 2) * units.smallSpacing)))
  
  There's a logic error. I'll rewrite it so you can see it.
  
    if (lineCount > 1) {
        return 0.5;
    } else {
       if (lineCount == 0) {   
          return 0;
       } else {
         return 2;
       }
    }

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham
Cc: Codezela, abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190109/953f72c7/attachment.html>