D15907: Compare float values in DecorationButton contains check

Vlad Zagorodniy noreply at phabricator.kde.org
Thu Feb 21 23:43:58 GMT 2019


zzag added a comment.


  Tests are not less important than the rest of the project. It's not good that we don't care about their readability.
  
  I'm not convinced by "current autotest fails without the change on current master and works with the patch". Please make the test simpler. I don't think that it will take too much time to reorganize the test table.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D15907

To: romangg, #kwin, zzag, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190221/28c7edd7/attachment.html>


More information about the Plasma-devel mailing list