D15907: Compare float values in DecorationButton contains check

[Roman Gilg]

romangg added a comment.


  In D15907#415347 <https://phabricator.kde.org/D15907#415347>, @zzag wrote:
  
  > Looks good to me.
  >
  > I think the test is too much complicated. Would it be simpler to have something like
  >
  >   QTest::addColumn<QRectF>("geometry");
  >   QTest::addColumn<QPointF>("pos");
  >   QTest::addColumn<bool>("contains");
  >
  >
  > ?
  
  
  Don't know. I've just checked again and the current autotest fails without the change on current master and works with the patch. I don't want to invest too much time in optimizing an autotest. If you think it can be done better, feel free to rewrite it.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D15907

To: romangg, #kwin, zzag, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190221/f1c9d2e9/attachment.html>