D15907: Compare float values in DecorationButton contains check

[Roman Gilg]

romangg added a comment.


  In D15907#417151 <https://phabricator.kde.org/D15907#417151>, @zzag wrote:
  
  > Tests are not less important than the rest of the project. It's not good that we don't care about their readability.
  
  
  Oh I do care about readability. Did you notice the huge diagram so auto test //readers// have a picture of what the test is doing?
  
  > I'm not convinced by "current autotest fails without the change on current master and works with the patch". Please make the test simpler. I don't think that it will take too much time to reorganize the test table.
  
  What's not to be convinced here? It's a fact, not an argument. No, I won't rewrite the test. If you want the autotest differently, do it yourself.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D15907

To: romangg, #kwin, zzag, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190222/c87815ce/attachment.html>