D18936: [weather] Fix weather Notices tab not showing

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D18936#410274 <https://phabricator.kde.org/D18936#410274>, @Zren wrote:
  
  > Ah, `NoticesView.qml` in Plasma 5.12 was slightly different.
  >
  > - https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/NoticesView.qml
  > - https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/Notice.qml
  >
  >   `Notice.qml` used `Column`, so I can't apply the heading centering in the first patch. Uhg. I forgot it still used a C++ `nativeInterface` model back then as well so it's... difficult to test.
  
  
  Eek, forgot about that as well. So 5.12 is more distant than I thought.
  
  > I'll just do do the `(model[0].length > 0 || model[1].length > 0)` + `Notice { visibility: model.length > 0 }` in the 5.12 commit.
  
  Okay, sounds good, that should fix the basic issue of not shown warnings at least.
  
  >   It'll probably have merge conflicts merging to 5.14 I'll need to fix which I could apply the centering in. Or should I make that a 2nd commit in the 5.14 branch?
  
  Whatever works best for you. Myself I usually do fixups directly in the merge commit.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18936

To: Zren, kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190212/a7673854/attachment-0001.html>