D18936: [weather] Fix weather Notices tab not showing

[Chris Holland]

Zren added a comment.


  Ah, `NoticesView.qml` in Plasma 5.12 was slightly different.
  
  - https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/NoticesView.qml
  - https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/Notice.qml
  
  `Notice.qml` used `Column`, so I can't apply the heading centering in the first patch. Uhg. I forgot it still used a C++ `nativeInterface` model back then as well so it's... difficult to test.
  
  I'll just do do the `(model[0].length > 0 || model[1].length > 0)` + `Notice { visibility: model.length > 0 }` in the 5.12 commit. It'll probably have merge conflicts merging to 5.14 I'll need to fix which I could apply the centering in. Or should I make that a 2nd commit in the 5.14 branch?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18936

To: Zren, kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190212/748a2f1f/attachment.html>