<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18936">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D18936#410274" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D18936#410274</a>, <a href="https://phabricator.kde.org/p/Zren/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@Zren</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Ah, <tt style="background: #ebebeb; font-size: 13px;">NoticesView.qml</tt> in Plasma 5.12 was slightly different.</p>
<ul class="remarkup-list">
<li class="remarkup-list-item"><a href="https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/NoticesView.qml" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/NoticesView.qml</a></li>
<li class="remarkup-list-item"><a href="https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/Notice.qml" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/Notice.qml</a>
<br /><br />
<tt style="background: #ebebeb; font-size: 13px;">Notice.qml</tt> used <tt style="background: #ebebeb; font-size: 13px;">Column</tt>, so I can't apply the heading centering in the first patch. Uhg. I forgot it still used a C++ <tt style="background: #ebebeb; font-size: 13px;">nativeInterface</tt> model back then as well so it's... difficult to test.</li>
</ul></div>
</blockquote>
<p>Eek, forgot about that as well. So 5.12 is more distant than I thought.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I'll just do do the <tt style="background: #ebebeb; font-size: 13px;">(model[0].length > 0 || model[1].length > 0)</tt> + <tt style="background: #ebebeb; font-size: 13px;">Notice { visibility: model.length > 0 }</tt> in the 5.12 commit.</p></blockquote>
<p>Okay, sounds good, that should fix the basic issue of not shown warnings at least.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">It'll probably have merge conflicts merging to 5.14 I'll need to fix which I could apply the centering in. Or should I make that a 2nd commit in the 5.14 branch?</pre></div></blockquote>
<p>Whatever works best for you. Myself I usually do fixups directly in the merge commit.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18936">https://phabricator.kde.org/D18936</a></div></div><br /><div><strong>To: </strong>Zren, kossebau, Plasma<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>