<table><tr><td style="">Zren added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18936">View Revision</a></tr></table><br /><div><div><p>Ah, <tt style="background: #ebebeb; font-size: 13px;">NoticesView.qml</tt> in Plasma 5.12 was slightly different.</p>

<ul class="remarkup-list">
<li class="remarkup-list-item"><a href="https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/NoticesView.qml" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/NoticesView.qml</a></li>
<li class="remarkup-list-item"><a href="https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/Notice.qml" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/Notice.qml</a></li>
</ul>

<p><tt style="background: #ebebeb; font-size: 13px;">Notice.qml</tt> used <tt style="background: #ebebeb; font-size: 13px;">Column</tt>, so I can't apply the heading centering in the first patch. Uhg. I forgot it still used a C++ <tt style="background: #ebebeb; font-size: 13px;">nativeInterface</tt> model back then as well so it's... difficult to test.</p>

<p>I'll just do do the <tt style="background: #ebebeb; font-size: 13px;">(model[0].length > 0 || model[1].length > 0)</tt> + <tt style="background: #ebebeb; font-size: 13px;">Notice { visibility: model.length > 0 }</tt> in the 5.12 commit. It'll probably have merge conflicts merging to 5.14 I'll need to fix which I could apply the centering in. Or should I make that a 2nd commit in the 5.14 branch?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18936">https://phabricator.kde.org/D18936</a></div></div><br /><div><strong>To: </strong>Zren, kossebau, Plasma<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>