D18936: [weather] Fix weather Notices tab not showing

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  `Toronto, ON` in the `Env Canada` ion currently has a weather warning. The weather widget's code currently has a bug that will only show the Notices tab if there's both a "warning" AND a "watch".
  
  This patch also hides the empty Warnings/Watches heading.
  
  -----
  
  The code populating the `noticesModel` is found here for reference:  
  https://github.com/KDE/kdeplasma-addons/blame/e0f0400dc7f263a29f86cf71924de6e9e24836d0/applets/weather/package/contents/ui/main.qml#L316
  
  F6608772: 2019-02-11___17-12-17.png <https://phabricator.kde.org/F6608772>
  
  We also fix the bug in the following screenshot:
  
  F6608783: 2019-02-11___17-17-08.png <https://phabricator.kde.org/F6608783>
  
  -----
  
  I don't see any existing bugs reporting this issue:  
  https://bugs.kde.org/buglist.cgi?component=weather&list_id=1587716&order=bug_id%20DESC&product=kdeplasma-addons&query_format=advanced

TEST PLAN
  - Patched `NoticesView.qml` and `SwitchPanel.qml` in `/usr/share/plasma/plasmoids/org.kde.plasma.weather/contents/ui/`
  - Ran `plasmawindowed org.kde.plasma.weather`
  - Selected a location with a warning

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18936

AFFECTED FILES
  applets/weather/package/contents/ui/NoticesView.qml
  applets/weather/package/contents/ui/SwitchPanel.qml

To: Zren
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190211/114495de/attachment-0001.html>