<table><tr><td style="">Zren created this revision.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />Zren requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18936">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p><tt style="background: #ebebeb; font-size: 13px;">Toronto, ON</tt> in the <tt style="background: #ebebeb; font-size: 13px;">Env Canada</tt> ion currently has a weather warning. The weather widget's code currently has a bug that will only show the Notices tab if there's both a "warning" AND a "watch".</p>

<p>This patch also hides the empty Warnings/Watches heading.</p>

<hr class="remarkup-hr" />

<p>The code populating the <tt style="background: #ebebeb; font-size: 13px;">noticesModel</tt> is found here for reference:  <br />
<a href="https://github.com/KDE/kdeplasma-addons/blame/e0f0400dc7f263a29f86cf71924de6e9e24836d0/applets/weather/package/contents/ui/main.qml#L316" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/kdeplasma-addons/blame/e0f0400dc7f263a29f86cf71924de6e9e24836d0/applets/weather/package/contents/ui/main.qml#L316</a></p>

<p><a href="https://phabricator.kde.org/F6608772" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F6608772: 2019-02-11___17-12-17.png</a></p>

<p>We also fix the bug in the following screenshot:</p>

<p><a href="https://phabricator.kde.org/F6608783" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F6608783: 2019-02-11___17-17-08.png</a></p>

<hr class="remarkup-hr" />

<p>I don't see any existing bugs reporting this issue:  <br />
<a href="https://bugs.kde.org/buglist.cgi?component=weather&list_id=1587716&order=bug_id%20DESC&product=kdeplasma-addons&query_format=advanced" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/buglist.cgi?component=weather&list_id=1587716&order=bug_id%20DESC&product=kdeplasma-addons&query_format=advanced</a></p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Patched <tt style="background: #ebebeb; font-size: 13px;">NoticesView.qml</tt> and <tt style="background: #ebebeb; font-size: 13px;">SwitchPanel.qml</tt> in <tt style="background: #ebebeb; font-size: 13px;">/usr/share/plasma/plasmoids/org.kde.plasma.weather/contents/ui/</tt></li>
<li class="remarkup-list-item">Ran <tt style="background: #ebebeb; font-size: 13px;">plasmawindowed org.kde.plasma.weather</tt></li>
<li class="remarkup-list-item">Selected a location with a warning</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18936">https://phabricator.kde.org/D18936</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/weather/package/contents/ui/NoticesView.qml<br />
applets/weather/package/contents/ui/SwitchPanel.qml</div></div></div><br /><div><strong>To: </strong>Zren<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>