D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare

Christoph Feck noreply at phabricator.kde.org
Mon Apr 8 22:07:21 BST 2019


cfeck added a comment.


  Are the `toLower()` calls really needed? I would have expected that `localeAwareCompare()` is case insensitive by default.
  
  Also, please use `return x` instead of `return (x)`.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D20386

To: jen6, #plasma, cfeck, pino, mlaurent
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190408/91197ba5/attachment.html>


More information about the Plasma-devel mailing list