D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare

Geon Son noreply at phabricator.kde.org
Mon Apr 8 19:27:02 BST 2019


jen6 created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jen6 requested review of this revision.

REVISION SUMMARY
  In TreeItem, there has two compare function itemNameLessThan and itemDescriptionLessThan.
  Those two functions were use < operator to compare string. But it doesn't consider about locale.
  So change compare function to QString::localeAwareCompare
  BUG: 404393

TEST PLAN
  Based on bug attachment, I add the Á and A to test it.

REPOSITORY
  R103 KMenu Editor

BRANCH
  comparePatch

REVISION DETAIL
  https://phabricator.kde.org/D20386

AFFECTED FILES
  treeview.cpp

To: jen6
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190408/ec61888e/attachment-0001.html>


More information about the Plasma-devel mailing list