D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare

Geon Son noreply at phabricator.kde.org
Tue Apr 9 02:54:34 BST 2019


jen6 added a comment.


  In D20386#446314 <https://phabricator.kde.org/D20386#446314>, @cfeck wrote:
  
  > Are the `toLower()` calls really needed? I would have expected that `localeAwareCompare()` is case insensitive by default.
  >
  > Also, please use `return x` instead of `return (x)`.
  
  
  Yep It seems the localeAwareCompare is insensitive by default. I'll change it

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D20386

To: jen6, #plasma, cfeck, pino, mlaurent
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190409/3194e8fd/attachment.html>


More information about the Plasma-devel mailing list