D16231: [ksmserver] Rewrite Startup

[Kai Uwe Broulik]

broulik added a comment.


  Pretty cool!

INLINE COMMENTS

> startup.cpp:94-95
> +        qCDebug(KSMSERVER) << "Phase 0";
> +        addSubjob(new AutoStartAppsJob(0));
> +        addSubjob(new KCMInitJob(1));
> +    }

Can these happen in parallel? In the old code (as far as I can understand it) it did auto start first and then kcminit phase 1? or does `addSubjob` queue them one after the other (doesn't look like it)?

> startup.cpp:143
>          }
>          Phonon::AudioOutput *m_audioOutput = new Phonon::AudioOutput(Phonon::NotificationCategory, &parent);
>  

As a next step I'd like to see this ported to libcanberra :P

> startup.cpp:206
> +        connect(loginSound, &NotificationThread::finished, loginSound, &NotificationThread::deleteLater);
> +        loginSound->start();});
> +    connect(phase2, &KJob::finished, this, &Startup::finishStartup);

Coding style, `});` on new line

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16231

To: davidedmundson, #plasma
Cc: broulik, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181017/508b09a1/attachment.html>