<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16231">View Revision</a></tr></table><br /><div><div><p>Pretty cool!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16231#inline-88399">View Inline</a><span style="color: #4b4d51; font-weight: bold;">startup.cpp:94-95</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">qCDebug</span><span class="p">(</span><span class="n">KSMSERVER</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Phase 0"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">addSubjob</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">AutoStartAppsJob</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">addSubjob</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">KCMInitJob</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can these happen in parallel? In the old code (as far as I can understand it) it did auto start first and then kcminit phase 1? or does <tt style="background: #ebebeb; font-size: 13px;">addSubjob</tt> queue them one after the other (doesn't look like it)?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16231#inline-88400">View Inline</a><span style="color: #4b4d51; font-weight: bold;">startup.cpp:143</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">Phonon</span><span style="color: #aa2211">::</span><span class="n">AudioOutput</span> <span style="color: #aa2211">*</span><span class="n">m_audioOutput</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">Phonon</span><span style="color: #aa2211">::</span><span class="n">AudioOutput</span><span class="p">(</span><span class="n">Phonon</span><span style="color: #aa2211">::</span><span class="n">NotificationCategory</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">parent</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">As a next step I'd like to see this ported to libcanberra :P</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16231#inline-88401">View Inline</a><span style="color: #4b4d51; font-weight: bold;">startup.cpp:206</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">connect</span><span class="p">(</span><span class="n">loginSound</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">NotificationThread</span><span style="color: #aa2211">::</span><span class="n">finished</span><span class="p">,</span> <span class="n">loginSound</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">NotificationThread</span><span style="color: #aa2211">::</span><span class="n">deleteLater</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">loginSound</span><span style="color: #aa2211">-></span><span class="n">start</span><span class="p">();});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">connect</span><span class="p">(</span><span class="n">phase2</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">KJob</span><span style="color: #aa2211">::</span><span class="n">finished</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">Startup</span><span style="color: #aa2211">::</span><span class="n">finishStartup</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Coding style, <tt style="background: #ebebeb; font-size: 13px;">});</tt> on new line</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16231">https://phabricator.kde.org/D16231</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>broulik, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>