D16231: [ksmserver] Rewrite Startup

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in startup.cpp:94-95
> Can these happen in parallel? In the old code (as far as I can understand it) it did auto start first and then kcminit phase 1? or does `addSubjob` queue them one after the other (doesn't look like it)?

Well read!

It was deliberate, but I should have commented it in the description.

Autostart apps job only launches, it doesn't (currently) block waiting for them to start.

Therefore it's effectively in parallel already.

> broulik wrote in startup.cpp:143
> As a next step I'd like to see this ported to libcanberra :P

Canberra has a systemd unit that plays startup/shutdown sounds automatically. It could be entirely someone elses problem. \o/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16231

To: davidedmundson, #plasma
Cc: broulik, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181017/741b376f/attachment-0001.html>