D17171: Set error if a kjob host disappears from kuiserver with active jobs

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If the host of a kjob crashes or is killed kuiserver currently reports
  that the job has been completed successfully. This is seriously wrong as
  it could lead a user to perform a potentially destructive operation.
  
  Setting any error (that's not 0 or 1) will cause plasmashell, the main
  kuiserver view, to show a persistent notification that a job has failed.
  
  For master I will use a more correct new enum, new error text, and a way
  to tell for KIO operations to report to the uiserver if the host
  crashing is important or not.
  
  CCBUG: 352761

TEST PLAN
  Whilst copying a million files killed dolphin
  Got a persistent error instead of a success message on the last file it was on
  
  Moving files successfully then killing the app remained fine

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17171

AFFECTED FILES
  kuiserver/progresslistmodel.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181126/3beeea98/attachment.html>