<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />davidedmundson requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17171">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>If the host of a kjob crashes or is killed kuiserver currently reports<br />
that the job has been completed successfully. This is seriously wrong as<br />
it could lead a user to perform a potentially destructive operation.</p>
<p>Setting any error (that's not 0 or 1) will cause plasmashell, the main<br />
kuiserver view, to show a persistent notification that a job has failed.</p>
<p>For master I will use a more correct new enum, new error text, and a way<br />
to tell for KIO operations to report to the uiserver if the host<br />
crashing is important or not.</p>
<p>CCBUG: 352761</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Whilst copying a million files killed dolphin<br />
Got a persistent error instead of a success message on the last file it was on</p>
<p>Moving files successfully then killing the app remained fine</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>origin-master (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17171">https://phabricator.kde.org/D17171</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kuiserver/progresslistmodel.cpp</div></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>