D17006: Compress calls to `updateSize`
Eike Hein
noreply at phabricator.kde.org
Mon Nov 19 07:25:32 GMT 2018
hein created this revision.
hein added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
hein requested review of this revision.
REVISION SUMMARY
Repeater+Flow has no reliable way to transactionize/batch insertion,
e.g. `Flow.positionCompleted` is useless in a function that can change
the Flow's size, and transition events like populated and similar
aren't available. Refactoring this to be a ListView isn't appealing
because it would mean the code loses the property of being reused for
both the bar and the popup, and therefore is well-tested already.
This brings down the number of `updateSize` calls when opening the
dialog for a group of five from five to one.
BUG:400364
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17006
AFFECTED FILES
applets/taskmanager/package/contents/ui/GroupDialog.qml
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181119/599cc1e9/attachment.html>
More information about the Plasma-devel
mailing list