<table><tr><td style="">hein created this revision.<br />hein added reviewers: Plasma, davidedmundson.<br />Herald added a project: Plasma.<br />hein requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17006">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Repeater+Flow has no reliable way to transactionize/batch insertion,<br />
e.g. <tt style="background: #ebebeb; font-size: 13px;">Flow.positionCompleted</tt> is useless in a function that can change<br />
the Flow's size, and transition events like populated and similar<br />
aren't available. Refactoring this to be a ListView isn't appealing<br />
because it would mean the code loses the property of being reused for<br />
both the bar and the popup, and therefore is well-tested already.</p>
<p>This brings down the number of <tt style="background: #ebebeb; font-size: 13px;">updateSize</tt> calls when opening the<br />
dialog for a group of five from five to one.</p>
<p>BUG:400364</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17006">https://phabricator.kde.org/D17006</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/taskmanager/package/contents/ui/GroupDialog.qml</div></div></div><br /><div><strong>To: </strong>hein, Plasma, davidedmundson<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>