D12804: Fix window frame rounding when scaling is used

Hugo Pereira Da Costa noreply at phabricator.kde.org
Mon May 14 14:08:36 UTC 2018


hpereiradacosta added a comment.


  In D12804#262291 <https://phabricator.kde.org/D12804#262291>, @davidedmundson wrote:
  
  > > IIRC, decoration renderer sets device pixel ratio, so in theory, you should not multiply frame radius by dpr.
  >
  > For some reason my comment went missing, but as zzag said, with high DPI here the only things we should ever change are pixmap sizes and  QPixmap::setDevicePixelRatio      not changing the (logical) size of what's actually being painted.
  
  
  So do I interpret this right when saying that the issue (which is real, judging from the screenshots), is "elsewhere" ? meaning "upstream" ? Meaning also that fixing it here will break in the future, once the upstream issue is found and fixed ?
  
  Most likely the actual issue is in kdecoration2 ...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12804

To: anemeth, #breeze, #vdg, hpereiradacosta, davidedmundson
Cc: zzag, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180514/7eed19b2/attachment.html>


More information about the Plasma-devel mailing list