D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

Alex Nemeth noreply at phabricator.kde.org
Mon Mar 26 14:43:23 UTC 2018


anemeth added a comment.


  In D9848#234268 <https://phabricator.kde.org/D9848#234268>, @zzag wrote:
  
  >
  
  
  
  
  > `GLRenderTarget::attachTexture`
  
  This was not changed.
  It was used by old blur and simple blur.
  Looks like it's not used anymore.
  
  > `GLRenderTarget::detachTexture`
  
  This was used by simple blur, but that has been removed in D10181 <https://phabricator.kde.org/D10181>
  I left it in in case something might use it in the future.
  
  > empty GLRenderTarget constructor
  
  Also was used by simple blur.
  
  > `GLRenderTarget::setTextureDirty`
  
  I added this because on line (1101 <---> 1124) the `disable()` function that also sets the texture dirty was moved into a condition.
  I don't know where the dirty parameter is used or checked, I didn't go look that far into it.
  
  For functions that are not used feel free to create a patch that removes them.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin, fredrik
Cc: hein, dos, luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, ragreen, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180326/6043700c/attachment-0001.html>


More information about the Plasma-devel mailing list