D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

Vlad Zagorodniy noreply at phabricator.kde.org
Mon Mar 26 15:22:58 UTC 2018


zzag added a comment.


  In D9848#234654 <https://phabricator.kde.org/D9848#234654>, @anemeth wrote:
  
  > > `GLRenderTarget::setTextureDirty`
  >
  > I added this because on line (1101 <---> 1124) the `disable()` function that also sets the texture dirty was moved into a condition.
  >  I don't know where the dirty parameter is used or checked, I didn't go look that far into it.
  
  
  It does nothing pretty much. https://github.com/KDE/kwin/blob/master/libkwineffects/kwingltexture.cpp#L569
  
  > For functions that are not used feel free to create a patch that removes them.
  
  No, I just asked why you added those changes, that's all. :)
  Also, I'm not a KWin developer so that's not up to me to decide whether they should be removed. ;-)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin, fredrik
Cc: hein, dos, luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, ragreen, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180326/307ca626/attachment.html>


More information about the Plasma-devel mailing list