D11606: [WebBrowser Plasmoid] Support opening external links
Kai Uwe Broulik
noreply at phabricator.kde.org
Fri Mar 23 10:21:13 UTC 2018
broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This implements a context menu for opening links externally. There is unfortunately currently no way to add custom context menu entries to `WebEngineView`'s context menu, so the link menu is completely replaced.
It also lets websites open new windows and fixes `target="_blank"` links
CCBUG: 371023
TEST PLAN
F5763534: Screenshot_20180323_112038.png <https://phabricator.kde.org/F5763534>
Verified that clicking a `<a href="file:///usr/bin/kate" target="_blank">` link does not result in that file being executed.
Unwanted popups are successfully blocked and show a hint
F5763531: Screenshot_20180323_111931.png <https://phabricator.kde.org/F5763531>
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D11606
AFFECTED FILES
applets/webbrowser/package/contents/ui/main.qml
To: broulik, #plasma, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180323/03ff527f/attachment.html>
More information about the Plasma-devel
mailing list