<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, VDG.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11606">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This implements a context menu for opening links externally. There is unfortunately currently no way to add custom context menu entries to <tt style="background: #ebebeb; font-size: 13px;">WebEngineView</tt>'s context menu, so the link menu is completely replaced.<br />
It also lets websites open new windows and fixes <tt style="background: #ebebeb; font-size: 13px;">target="_blank"</tt> links</p>
<p>CCBUG: 371023</p></div></div><br /><div><strong>TEST PLAN</strong><div><p><a href="https://phabricator.kde.org/F5763534" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5763534: Screenshot_20180323_112038.png</a><br />
Verified that clicking a <tt style="background: #ebebeb; font-size: 13px;"><a href="file:///usr/bin/kate" target="_blank"></tt> link does not result in that file being executed.<br />
Unwanted popups are successfully blocked and show a hint<br />
<a href="https://phabricator.kde.org/F5763531" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5763531: Screenshot_20180323_111931.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11606">https://phabricator.kde.org/D11606</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/webbrowser/package/contents/ui/main.qml</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG<br /><strong>Cc: </strong>plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>