D11606: [WebBrowser Plasmoid] Support opening external links

[David Edmundson]

davidedmundson added a comment.


  In general fine.

INLINE COMMENTS

> main.qml:65-67
> +            // button itself adds sufficient visual padding
> +            Layout.leftMargin: -parent.spacing
> +            Layout.rightMargin: -parent.spacing

You can find a better solution. Especially as there's only 3 items (two spaces) in this Layout.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11606

To: broulik, #plasma, #vdg
Cc: davidedmundson, Murz, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180324/739e6d6a/attachment.html>