D14418: Add test for edid parsing and fix reading gamma
Roman Gilg
noreply at phabricator.kde.org
Fri Jul 27 10:15:08 BST 2018
romangg added a comment.
I'm not sure if you could really say that the current code is with a bug, since `data[GCM_EDID_OFFSET_GAMMA]` should be dividable by 100. I.e. the result is again an integer and nothing gets truncated. But we can still go with the updated code, which looks nicer. Maybe one could add a comment why divide by 100 and add 1.
In regards to the parser test in the edid test:
- How did you choose the four brands/models to test?
- Pls order the rows alphabetically by brand/model name.
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D14418
To: gladhorn, #plasma, romangg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180727/6e00fadf/attachment.html>
More information about the Plasma-devel
mailing list