D10200: base listitemdelegate color on selected, not checked

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> DefaultListItemBackground.qml:25
>      id: background
> -    color: listItem.checked || (listItem.supportsMouseEvents && listItem.pressed && !listItem.checked && !listItem.sectionDelegate) ? (internal.indicateActiveFocus ? listItem.activeBackgroundColor : Qt.tint(listItem.backgroundColor, Qt.rgba(listItem.activeBackgroundColor.r, listItem.activeBackgroundColor.g, listItem.activeBackgroundColor.b, 0.3))) : listItem.backgroundColor
> +    color: listItem.selected || (listItem.supportsMouseEvents && listItem.pressed && !listItem.selected && !listItem.sectionDelegate) ? (internal.indicateActiveFocus ? listItem.activeBackgroundColor : Qt.tint(listItem.backgroundColor, Qt.rgba(listItem.activeBackgroundColor.r, listItem.activeBackgroundColor.g, listItem.activeBackgroundColor.b, 0.3))) : listItem.backgroundColor
>  

the bug is actually in that Qt.tint() call which was trying to generate the inactive selection color, but is wrong.

the background color should still change like it did, like everything else (like the dolphin sidebar does for instance) if we want to disable it, we should disable it globally, and is a checkbox in the colors kcm

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10200

To: sebas, hein, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180131/2c069744/attachment-0001.html>