<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10200" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10200#inline-47048" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DefaultListItemBackground.qml:25</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">id: background</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">color:</span> <span style="color: #004012">listItem</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">checked</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">listItem</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">supportsMouseEvents</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">listItem</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">pressed</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">!</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">listItem</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">check</span>ed</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span style="color: #004012">listItem</span><span class="p">.</span><span style="color: #004012">sectionDelegate</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span class="p">(</span><span style="color: #004012">internal</span><span class="p">.</span><span style="color: #004012">indicateActiveFocus</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">listItem.activeBackgroundColor :</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">tint</span><span class="p">(</span><span style="color: #004012">listItem</span><span class="p">.</span><span style="color: #004012">backgroundColor</span><span class="p">,</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">rgba</span><span class="p">(</span><span style="color: #004012">listItem</span><span class="p">.</span><span style="color: #004012">activeBackgroundColor</span><span class="p">.</span><span style="color: #004012">r</span><span class="p">,</span> <span style="color: #004012">listItem</span><span class="p">.</span><span style="color: #004012">activeBackgroundColor</span><span class="p">.</span><span style="color: #004012">g</span><span class="p">,</span> <span style="color: #004012">listItem</span><span class="p">.</span><span style="color: #004012">activeBackgroundColor</span><span class="p">.</span><span style="color: #004012">b</span><span class="p">,</span> <span style="color: #601200">0.3</span><span class="p">)))</span> <span style="color: #aa2211">:</span> <span style="color: #004012">listItem</span><span class="p">.</span><span style="color: #004012">backgroundColor</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">color:</span> <span style="color: #004012">listItem</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">selected</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">listItem</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">supportsMouseEvents</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">listItem</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">pressed</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">!</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">listItem</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">select</span>ed</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span style="color: #004012">listItem</span><span class="p">.</span><span style="color: #004012">sectionDelegate</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span class="p">(</span><span style="color: #004012">internal</span><span class="p">.</span><span style="color: #004012">indicateActiveFocus</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">listItem.activeBackgroundColor :</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">tint</span><span class="p">(</span><span style="color: #004012">listItem</span><span class="p">.</span><span style="color: #004012">backgroundColor</span><span class="p">,</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">rgba</span><span class="p">(</span><span style="color: #004012">listItem</span><span class="p">.</span><span style="color: #004012">activeBackgroundColor</span><span class="p">.</span><span style="color: #004012">r</span><span class="p">,</span> <span style="color: #004012">listItem</span><span class="p">.</span><span style="color: #004012">activeBackgroundColor</span><span class="p">.</span><span style="color: #004012">g</span><span class="p">,</span> <span style="color: #004012">listItem</span><span class="p">.</span><span style="color: #004012">activeBackgroundColor</span><span class="p">.</span><span style="color: #004012">b</span><span class="p">,</span> <span style="color: #601200">0.3</span><span class="p">)))</span> <span style="color: #aa2211">:</span> <span style="color: #004012">listItem</span><span class="p">.</span><span style="color: #004012">backgroundColor</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the bug is actually in that Qt.tint() call which was trying to generate the inactive selection color, but is wrong.</p>
<p style="padding: 0; margin: 8px;">the background color should still change like it did, like everything else (like the dolphin sidebar does for instance) if we want to disable it, we should disable it globally, and is a checkbox in the colors kcm</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10200" rel="noreferrer">https://phabricator.kde.org/D10200</a></div></div><br /><div><strong>To: </strong>sebas, hein, mart<br /><strong>Cc: </strong>plasma-devel, apol, davidedmundson, mart, hein<br /></div>