D9803: Apply some C++11 niceties, styling consistency

Oleg Chernovskiy noreply at phabricator.kde.org
Thu Jan 11 19:01:47 UTC 2018


Kanedias added inline comments.

INLINE COMMENTS

> apol wrote in plasmadesktoptheme.cpp:160
> if you make it `auto` the initializer_list will be used not requiring the allocation AFAIU.
> That said, I wonder if the compiler can unwind a foreach.

I didn't quite get it, you mean we can write `for (auto state : { QPalette::Active, QPalette::Inactive, QPalette::Disabled })` to get rid of allocation of `states` array?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D9803

To: Kanedias, mart
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180111/325713bd/attachment.html>


More information about the Plasma-devel mailing list