D9803: Apply some C++11 niceties, styling consistency

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Jan 11 02:15:59 UTC 2018


apol added inline comments.

INLINE COMMENTS

> plasmadesktoptheme.cpp:160
>      QPalette pal = palette();
>      static const QPalette::ColorGroup states[3] = { QPalette::Active, QPalette::Inactive, QPalette::Disabled };
> +    for (auto state : states) {

if you make it `auto` the initializer_list will be used not requiring the allocation AFAIU.
That said, I wonder if the compiler can unwind a foreach.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D9803

To: Kanedias, mart
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180111/faadf943/attachment-0001.html>


More information about the Plasma-devel mailing list